Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wavelet Power Spectra #237

Merged
merged 7 commits into from
Dec 20, 2023
Merged

Wavelet Power Spectra #237

merged 7 commits into from
Dec 20, 2023

Conversation

jrs65
Copy link
Contributor

@jrs65 jrs65 commented Apr 3, 2023

  • refactor(DelaySpectrumEstimatorBase): remove unnecessary setup method
  • refactor(delay): routine to flatten selected axes of a distributed dataset
  • feat(wavelet): wavelet power spectrum estimation

@ljgray ljgray mentioned this pull request Apr 18, 2023
Open
@jrs65 jrs65 marked this pull request as ready for review July 26, 2023 21:25
@jrs65 jrs65 requested a review from sjforeman July 26, 2023 21:26
@jrs65 jrs65 requested a review from ljgray December 19, 2023 12:37
@jrs65
Copy link
Contributor Author

jrs65 commented Dec 19, 2023

@ljgray I've rebased and fixed this up to work with the most recent master. If you could take a look that would be great. Expect a few more PRs with the delay cross spectrum code to come after this one.

ljgray
ljgray approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@ljgray ljgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor looks fine, just mentioning a couple of things. PyWavelets should also be added as an install requirement

draco/util/_fast_tools.pyx Outdated Show resolved Hide resolved
draco/analysis/wavelet.py Outdated Show resolved Hide resolved
@jrs65 jrs65 merged commit 7810861 into master Dec 20, 2023
4 checks passed
@ljgray ljgray mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljgray ljgray ljgray approved these changes

@sjforeman sjforeman Awaiting requested review from sjforeman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrs65 @ljgray